Remove vg join (been deprecated since 2020)#4932
Open
faithokamoto wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Also, you can do exactly what vg join is for by just manipulating GFAs. I did that for Centrolign and it worked fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg joinis removedDescription
Another of the subcommands we deprecated back in 2020 with #3136.
vg joinis problematic: #2515 (comment) (comment from 2019):That issue thread also suggests removing
vg concat, which also does unexpected things #2502 (comment) -- exceptvg concatdoes some useful things too, e.g. see it being recommended here #2688. So I am not sure whether it should be murdered with fire. Thus this PR only removesvg join.